Open
Conversation
- Modify _set_flag to work on _flags only and update shader param - Use VectorX.ZERO constant for clarity - Make constants _DEFAULT_TEXTURE and _DEFAULT_CURVE resources instead of strings - Remove moot setter _set_scroll - Manually set flags in _ready() instead of relying on setters and rewriting shader param 4 extra times - Formatting tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the cool plugin! Made some tweaks to GPUTrail.gd to make the code easier to read. Hope you find this useful